drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #597: DRILL-4905: Push down the LIMIT to the parquet read...
Date Thu, 29 Sep 2016 20:58:19 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/597#discussion_r81232963
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -864,6 +872,14 @@ public String getDigest() {
         return toString();
       }
     
    +  public void setCacheFileRoot(String cacheFileRoot) {
    +    this.cacheFileRoot = cacheFileRoot;
    +  }
    +
    +  public void setBatchSize(long batchSize) {
    +    this.recommendedBatchSize = batchSize;
    --- End diff --
    
    Would it be good to add an assert to check recommendedBatchSize <= PARQUET_READER_RECORD_BATCH_SIZE
max_value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message