drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #597: DRILL-4905: Push down the LIMIT to the parquet read...
Date Wed, 28 Sep 2016 17:11:49 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/597#discussion_r80968936
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -125,13 +125,14 @@
       String PARQUET_WRITER_ENABLE_DICTIONARY_ENCODING = "store.parquet.enable_dictionary_encoding";
       OptionValidator PARQUET_WRITER_ENABLE_DICTIONARY_ENCODING_VALIDATOR = new BooleanValidator(
           PARQUET_WRITER_ENABLE_DICTIONARY_ENCODING, false);
    -
       String PARQUET_VECTOR_FILL_THRESHOLD = "store.parquet.vector_fill_threshold";
       OptionValidator PARQUET_VECTOR_FILL_THRESHOLD_VALIDATOR = new PositiveLongValidator(PARQUET_VECTOR_FILL_THRESHOLD,
99l, 85l);
       String PARQUET_VECTOR_FILL_CHECK_THRESHOLD = "store.parquet.vector_fill_check_threshold";
       OptionValidator PARQUET_VECTOR_FILL_CHECK_THRESHOLD_VALIDATOR = new PositiveLongValidator(PARQUET_VECTOR_FILL_CHECK_THRESHOLD,
100l, 10l);
       String PARQUET_NEW_RECORD_READER = "store.parquet.use_new_reader";
       OptionValidator PARQUET_RECORD_READER_IMPLEMENTATION_VALIDATOR = new BooleanValidator(PARQUET_NEW_RECORD_READER,
false);
    +  String PARQUET_RECORD_BATCH_SIZE = "store.parquet.record_batch_size";
    --- End diff --
    
    It would be nice to use "store.parquet.reader.record_batch_size", since this option is
for reader only, not for parquet writer.  We could not change the option name once it's released.

    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message