drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Tue, 27 Sep 2016 16:42:55 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r80647672
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -179,14 +190,15 @@ public DrillFuncHolder findExactMatchingDrillFunction(String name,
List<MajorTyp
       }
     
       private DrillFuncHolder findExactMatchingDrillFunction(String name, List<MajorType>
argTypes, MajorType returnType, boolean retry) {
    -    for (DrillFuncHolder h : drillFuncRegistry.getMethods(name)) {
    +    AtomicLong version = new AtomicLong();
    --- End diff --
    
    We use AtomicLong to hold local registry version, when we call localFunctionRegistry.getMethods(name,
version) we pass our AtomicLong and it's enriched with current local version registry number.
Please see FunctionRegistryHolder.getMethods description for more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message