drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Mon, 26 Sep 2016 21:53:22 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r80542988
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -179,14 +190,15 @@ public DrillFuncHolder findExactMatchingDrillFunction(String name,
List<MajorTyp
       }
     
       private DrillFuncHolder findExactMatchingDrillFunction(String name, List<MajorType>
argTypes, MajorType returnType, boolean retry) {
    -    for (DrillFuncHolder h : drillFuncRegistry.getMethods(name)) {
    +    AtomicLong version = new AtomicLong();
    --- End diff --
    
    Not entirely clear how the version works. We create it here and intialze it to 0. Then
in loadRemoteFunctions( ), we compare the local version (always 0) to the registry version
(which will be zero only until, presumably, the first load.) Are we missing an initialization
here to the current registry version? Else, please explain how this works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message