drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Sun, 11 Sep 2016 11:06:33 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r78292645
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -138,18 +171,25 @@ private String functionReplacement(FunctionCall functionCall) {
     
       /**
        * Find the Drill function implementation that matches the name, arg types and return
type.
    -   * @param name
    -   * @param argTypes
    -   * @param returnType
    -   * @return
    +   * If exact function implementation was not found and in case if Dynamic UDF Support
is enabled
    +   * loads all missing remote functions and tries to find Drill implementation one more
time.
        */
       public DrillFuncHolder findExactMatchingDrillFunction(String name, List<MajorType>
argTypes, MajorType returnType) {
    +    return findExactMatchingDrillFunction(name, argTypes, returnType, true);
    +  }
    +
    +  private DrillFuncHolder findExactMatchingDrillFunction(String name, List<MajorType>
argTypes, MajorType returnType, boolean retry) {
         for (DrillFuncHolder h : drillFuncRegistry.getMethods(name)) {
           if (h.matches(returnType, argTypes)) {
             return h;
           }
         }
     
    +    if (retry && optionManager != null && optionManager.getOption(ExecConstants.DYNAMIC_UDF_SUPPORT_ENABLED).bool_val)
{
    +      if (loadRemoteFunctions()) {
    --- End diff --
    
    Agree. I'll make loadFunctions method thread-safe.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message