drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Wed, 07 Sep 2016 22:40:38 GMT
Github user paul-rogers commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/store/ZookeeperPersistentStore.java
    @@ -63,7 +63,18 @@ public PersistentStoreMode getMode() {
       public V get(final String key) {
    -    final byte[] bytes = client.get(key);
    +    return get(key, null);
    --- End diff --
    Minor point... Should this version simply call client.get as before? Should the version
that takes a version require the version? Would seem to keep things a bit simpler that way...

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message