drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Wed, 07 Sep 2016 00:35:14 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77743717
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionInitializer.java
---
    @@ -42,22 +42,29 @@
     public class FunctionInitializer {
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(FunctionInitializer.class);
     
    -  private String className;
    -
    +  private final String className;
    +  private final ClassLoader classloader;
       private Map<String, CompilationUnit> functionUnits = Maps.newHashMap();
       private Map<String, String> methods;
       private List<String> imports;
       private volatile boolean ready;
     
       /**
        * @param className the fully qualified name of the class implementing the function
    +   * @param classLoader system or custom class loader
    --- End diff --
    
    Please explain the purpose of the class loader: how is it used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message