drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Wed, 07 Sep 2016 00:07:01 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77741203
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionImplementationRegistry.java
---
    @@ -86,6 +108,7 @@ public FunctionImplementationRegistry(DrillConfig config, ScanResult
classpathSc
           }
         }
         logger.info("Function registry loaded.  {} functions loaded in {} ms.", drillFuncRegistry.size(),
w.elapsed(TimeUnit.MILLISECONDS));
    +    this.remoteFunctionRegistry = new RemoteFunctionRegistry(new UnregistrationListener());
    --- End diff --
    
    Should this loader also be surrounded by a timer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message