drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Tue, 06 Sep 2016 18:12:02 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77688808
  
    --- Diff: common/src/main/java/org/apache/drill/common/config/DrillConfig.java ---
    @@ -164,6 +164,15 @@ public static DrillConfig create(String overrideFileResourcePathname,
boolean en
       }
     
       /**
    +   * Creates a drill configuration using the provided config file.
    --- End diff --
    
    What is this for? Is the caller responsible for loading the defaults? If this is primarily
for unit testing, then the comment should say so and describe how to use this. (The config,
for example, must provide all required properties; nothing will be picked up from defaults.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message