drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Mon, 05 Sep 2016 10:30:25 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77501913
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -189,6 +189,15 @@ drill.exec: {
       debug: {
         return_error_for_failure_in_cancelled_fragments: false
       }
    +  udf: {
    +    retry.times: 5,
    +    directory: {
    +      base: "/tmp",
    +      staging: ${drill.exec.zk.root}"/udf/staging",
    --- End diff --
    
    Using drill.dfs.home is not quite right, since I am not obliging user to use dfs. User
can user fs, if he is running Drill in embedded more or just using one node (let's say for
developing / testing purposes). Though I might use drill.fs.home and default it to /user/drill.
    
    staging: ${drill.exec.zk.root}"/udf/staging" - corresponds to directory, not znode and
I need ${drill.exec.zk.root} to separate jars from different Drill clusters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message