drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Mon, 05 Sep 2016 09:41:39 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77495658
  
    --- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
    @@ -298,3 +298,17 @@ enum CoreOperatorType {
       NESTED_LOOP_JOIN = 35;
       AVRO_SUB_SCAN = 36;
     }
    +
    +message Func {
    +  optional string name = 1;
    +  repeated common.MajorType major_type = 2;
    --- End diff --
    
    It's type of in parameter. For example, toString of common.MajorType class:
    "major_type {\n" +
     +        "  minor_type: VARCHAR\n" +
     +        "  mode: REQUIRED\n" +
     +        "}\n
    I can update name to type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message