drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Fri, 02 Sep 2016 22:46:31 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77421971
  
    --- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
    @@ -298,3 +298,17 @@ enum CoreOperatorType {
       NESTED_LOOP_JOIN = 35;
       AVRO_SUB_SCAN = 36;
     }
    +
    +message Func {
    +  optional string name = 1;
    +  repeated common.MajorType major_type = 2;
    +}
    +
    +message Jar {
    +  optional string name = 1;
    +  repeated Func function = 2;
    +}
    +
    +message Registry {
    --- End diff --
    
    When do we exchange a registry of Jars? Is this stored in ZK? If so, do we have to worry
about the total size of the resulting ZK zNode? Have we done performance checks to see what
happens if the user has registered, say, 100 jars of 5 functions each? Should we consider
a ZK structure (if that is what this is for)  of the form:
    
    .../udfs
      jar1: <JAR>
      jar2: <JAR>
    
    That is, store the list of jars as zNodes, where each zNode defines one jar?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message