drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Fri, 02 Sep 2016 22:41:28 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77421538
  
    --- Diff: protocol/src/main/protobuf/UserBitShared.proto ---
    @@ -298,3 +298,17 @@ enum CoreOperatorType {
       NESTED_LOOP_JOIN = 35;
       AVRO_SUB_SCAN = 36;
     }
    +
    +message Func {
    +  optional string name = 1;
    +  repeated common.MajorType major_type = 2;
    --- End diff --
    
    What does major type mean for a function? Is this the parameter type? The return type?
Something else? Perhaps choose a clearer name or include a comment to explain the meaning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message