drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Fri, 02 Sep 2016 18:50:30 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77395331
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -366,11 +366,18 @@ if [ $? -eq 0 ]; then
       fatal_error "Java 1.7 or later is required to run Apache Drill."
     fi
     
    +# Create Drill local udf area, if it does not exist
    +DRILL_UDF_DIR="$DRILL_HOME/udf"
    +if [[ ! -d "$DRILL_UDF_DIR" ]]; then
    +  mkdir -p "$DRILL_UDF_DIR"
    +fi
    +
    --- End diff --
    
    This should be $DRILL_CONF_DIR/udf, not $DRILL_HOME. $DRILL_CONF_DIR points to the user's
"site" directory, which will be outside of $DRILL_HOME for Drill-on-YARN.
    
    Not sure we need to create this directory. The pattern followed elsewhere is to include
the directory on the class path if it exists.
    
    In Drill-on-YARN, we CAN'T create the directory; the "localized" Drill and site directories
are read-only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message