drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #572: DRILL-4854: Fix logic error in drill-config.sh
Date Thu, 18 Aug 2016 19:42:23 GMT
GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/572

    DRILL-4854: Fix logic error in drill-config.sh

    This change should go into 1.8 as it fixes a minor regression introduced during 1.8.
    
    The recent changes to the launch scripts introduced a subtle bug in the logic that verifies
the log directory:
    
        if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then
        ...
        if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then
    
    In both cases, the operator should be or ("||"). That is, if either the item is not a
directory, or it is a directory but is not writable, then do the fall-back steps.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-4854

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #572
    
----
commit 9f3b282a7cdfd2a2c4dda49372f1256b16db3005
Author: Paul Rogers <progers@maprtech.com>
Date:   2016-08-18T19:39:45Z

    DRILL-4854: Fix logic error in drill-config.sh
    
    The check of the log directory should use an OR instead of AND.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message