drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rogers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-4854) Incorrect logic in log directory checks in drill-config.sh
Date Thu, 18 Aug 2016 19:37:22 GMT
Paul Rogers created DRILL-4854:
----------------------------------

             Summary: Incorrect logic in log directory checks in drill-config.sh
                 Key: DRILL-4854
                 URL: https://issues.apache.org/jira/browse/DRILL-4854
             Project: Apache Drill
          Issue Type: Bug
    Affects Versions: 1.8.0
            Reporter: Paul Rogers
            Assignee: Paul Rogers
            Priority: Minor
             Fix For: 1.8.0


The recent changes to the launch scripts introduced a subtle bug in the logic that verifies
the log directory:

  if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then
    ...

if [[ ! -d "$DRILL_LOG_DIR" && ! -w "$DRILL_LOG_DIR" ]]; then

In both cases, the operator should be or ("||").

That is, if either the item is not a directory, or it is a directory but is not writable,
then do the fall-back steps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message