drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rogers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-4817) Eliminate redundant call to zeroVectors in FilterRecordBatch
Date Mon, 01 Aug 2016 04:20:20 GMT
Paul Rogers created DRILL-4817:
----------------------------------

             Summary: Eliminate redundant call to zeroVectors in FilterRecordBatch
                 Key: DRILL-4817
                 URL: https://issues.apache.org/jira/browse/DRILL-4817
             Project: Apache Drill
          Issue Type: Improvement
          Components: Execution - Flow
    Affects Versions: 1.7.0
            Reporter: Paul Rogers
            Priority: Minor


Consider the FilterRecordBatch class. This class derives from AbstractSingleRecordBatch (ASRB).
ASRB.innerNext( ) has the following code:

      container.zeroVectors();
      IterOutcome out = doWork();

Now, consider FilterRecordBatch.doWork( ):

    protected IterOutcome doWork() {
      container.zeroVectors();
      ...

Notice that the net effect is to zero the vectors twice, spinning the CPU unnecessarily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message