drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Laurent Goujon <laur...@dremio.com>
Subject Re: C++ protobuf files
Date Thu, 18 Aug 2016 17:06:02 GMT
I just opened DRILL-4853 jira and PR
https://github.com/apache/drill/pull/571 for the protobuf source files
update.

Laurent

On Thu, Aug 18, 2016 at 9:49 AM, Laurent Goujon <laurent@dremio.com> wrote:

> Thanks Sékine,
>
> After fiddling around and with a little help from Venki (who told me about
> the CMakeList.txt files under src/protobuf), I was able to refresh the
> files using the following command in the build directory:
> $ make fixProtobufs cpProtobufs
>
> This should copy the refreshed files over to the c++ src directory.
>
> Laurent
>
> On Thu, Aug 18, 2016 at 1:01 AM, Sékine Coulibaly <scoulibaly@gmail.com>
> wrote:
>
>> Laurent,
>>
>> I used this on  1.7 branch (commit 7800aebdca845466a8d912f0f59c00
>> cda093b01f)
>>  :
>>
>> PYTHONPATH="/home/scoulibaly/python/build/lib.linux-x86_64-2.7"
>> /home/scoulibaly/protobuf/src/protoc  --cpp_out="." --proto_path="."
>> *.proto
>>
>> Just update to your actual Python path and to your actual protoc binary
>> path.
>>
>> The output on my machine is as follow :
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: BitControl.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: ExecutionProtos.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: Coordination.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: UserBitShared.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: Types.proto. Please use 'syntax = "proto2";'
>> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
>> syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: SchemaDef.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: BitData.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> BitData.proto: warning: Import Coordination.proto but not used.
>> BitData.proto: warning: Import ExecutionProtos.proto but not used.
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: GeneralRPC.proto. Please use 'syntax =
>> "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted
>> to proto2 syntax.)
>> GeneralRPC.proto: warning: Import Coordination.proto but not used.
>> [libprotobuf WARNING google/protobuf/compiler/parser.cc:547] No syntax
>> specified for the proto file: User.proto. Please use 'syntax = "proto2";'
>> or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2
>> syntax.)
>> User.proto: warning: Import BitData.proto but not used.
>> User.proto: warning: Import ExecutionProtos.proto but not used.
>> User.proto: warning: Import SchemaDef.proto but not used.
>>
>> Hope this will help you start.
>>
>>
>> 2016-08-17 20:01 GMT+02:00 Laurent Goujon <laurent@dremio.com>:
>>
>> > Hi,
>> >
>> > There's no instructions on how to generate the C++ protobuf files, and
>> they
>> > are currently out-of-sync with the definitions stored under protocol
>> > module.
>> >
>> > Does someone know how these files are generated? I'd like to update them
>> > and add some instructions at the same time.
>> >
>> > Cheers,
>> >
>> > Laurent
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message