drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #575: DRILL-4857: Maintain pruning status and populate Pa...
Date Tue, 23 Aug 2016 22:33:59 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/575#discussion_r75964268
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -173,8 +173,18 @@ public ParquetGroupScan( //
         final FileSelection fileSelection = expandIfNecessary(selection);
     
         this.entries = Lists.newArrayList();
    -    for (String fileName : fileSelection.getFiles()) {
    -      entries.add(new ReadEntryWithPath(fileName));
    +    if (fileSelection.getMetaContext() != null &&
    +        (fileSelection.getMetaContext().wasPruningStarted() &&
    +        ! fileSelection.getMetaContext().wasPruned())) {
    +      // if pruning was attempted and nothing was pruned, initialize the entries with
just
    +      // the selection root instead of the fully expanded list to reduce overhead. The
fully
    +      // expanded list is already stored as part of the fileSet.
    +      // TODO: at some point we should examine whether the list of entries is absolutely
needed.
    --- End diff --
    
    Maybe we log a JIRA for this TODO, so that we keep track of this issue? Seems it makes
sense to either use the list of entries, or fileSet, but not both. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message