drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request #532: DRILL-4732: Update JDBC driver to use the new prepa...
Date Mon, 08 Aug 2016 19:46:06 GMT
Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/532#discussion_r73940855
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java
---
    @@ -362,12 +364,33 @@ public PreparedStatement prepareStatement(String sql, int resultSetType,
                                                 int resultSetHoldability) throws SQLException
{
         throwIfClosed();
         try {
    -      DrillPrepareResult prepareResult = new DrillPrepareResult(sql);
    +      DrillRpcFuture<CreatePreparedStatementResp> respFuture = client.createPreparedStatement(sql);
    +
    +      CreatePreparedStatementResp resp;
    +      try {
    +        resp = respFuture.get();
    +      } catch (InterruptedException e) {
    +        // Preserve evidence that the interruption occurred so that code higher up
    +        // on the call stack can learn of the interruption and respond to it if it
    +        // wants to.
    +        Thread.currentThread().interrupt();
    +
    +        throw new SQLException( "Interrupted", e );
    --- End diff --
    
    From [1], we remove the RpcFuture when the response is received, and set the status in
Future. Nobody is going to process it, as the client is not looking for a response anymore.
I am trying to understand who you mean by processing?
    
    [1] https://github.com/apache/drill/blob/master/exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcBus.java#L412


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message