drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Fri, 05 Aug 2016 20:52:20 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r73757533
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
    @@ -139,6 +151,24 @@ public SqlNode parse(String sql) {
           SqlParser parser = SqlParser.create(sql, parserConfig);
           return parser.parseStmt();
         } catch (SqlParseException e) {
    +
    +      // Attempt to use default back_tick quote character for identifiers when
    --- End diff --
    
    One of the requirements was still working identifiers with backticks even while ANSI_QUOTES
mode is on.
    `sql.contains("`")` condition isn't mandatory here. It was removed in a new commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message