drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #559: DRILL-4825: Fix incorrect result issue caused by pa...
Date Fri, 05 Aug 2016 06:57:38 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/559#discussion_r73649603
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -402,4 +402,18 @@ public String getCacheFileRoot() {
         return cacheFileRoot;
       }
     
    +  @Override
    +  public String toString() {
    +    final StringBuilder sb = new StringBuilder();
    +    sb.append("root=" + this.selectionRoot);
    +
    +    sb.append("files=[");
    +    for (final String file : this.files) {
    +      sb.append(file);
    --- End diff --
    
    Is this method only used internally or would it show up in the Explain output ?  If latter,
you may add a comma or space after each file name. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message