drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #549: DRILL-4682: Allow full schema identifier in SELECT ...
Date Tue, 02 Aug 2016 20:08:33 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/549#discussion_r73227364
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillCompoundIdentifier.java
---
    @@ -69,31 +70,38 @@ public void addIndex(int index, SqlParserPos pos){
         }
       }
     
    -  public SqlNode getAsSqlNode(){
    -    if(ids.size() == 1){
    +  public SqlNode getAsSqlNode(Set<DrillCompoundIdentifier> fullSchemasSet) {
    --- End diff --
    
    I feel we should not maintain and pass in this fullSchemaSet.  Seems to what you are doing
is to put some validation logic in parser, which is not right way to do so. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message