Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-547-drill@git.apache.org>
In-Reply-To: <git-pr-547-drill@git.apache.org>
Subject: [GitHub] drill pull request #547: Drill-4581: Extensive revisions to the Drill launch...
Content-Type: text/plain
Message-Id: <20160721045521.303F8E04BA@git1-us-west.apache.org>
Date: Thu, 21 Jul 2016 04:55:21 +0000 (UTC)
archived-at: Thu, 21 Jul 2016 04:55:23 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/547#discussion_r71646935
  
    --- Diff: distribution/src/resources/drill-config.sh ---
    @@ -193,21 +366,24 @@ if $is_cygwin; then
       DRILL_LOG_DIR=`cygpath -w "$DRILL_LOG_DIR"`
       CP=`cygpath -w -p "$CP"`
       if [ -z "$HADOOP_HOME" ]; then
    -    HADOOP_HOME=${DRILL_HOME}/winutils
    +    export HADOOP_HOME=${DRILL_HOME}/winutils
       fi
     fi
     
     # make sure allocator chunks are done as mmap'd memory (and reduce arena overhead)
    -export MALLOC_ARENA_MAX=4
    +# Newer versions of glibc use an arena memory allocator that causes virtual
    +# memory usage to explode. Tune the variable down to prevent vmem explosion.
    +export MALLOC_ARENA_MAX=${MALLOC_ARENA_MAX:-4}
     export MALLOC_MMAP_THRESHOLD_=131072
     export MALLOC_TRIM_THRESHOLD_=131072
     export MALLOC_TOP_PAD_=131072
     export MALLOC_MMAP_MAX_=65536
     
     # Variables exported form this script
    -export HADOOP_HOME
     export is_cygwin
     export DRILL_HOME
     export DRILL_CONF_DIR
     export DRILL_LOG_DIR
     export CP
    +export JAVA_HOME
    +export JAVA
    --- End diff --
    
    The original ones are, well, original, so I let the as is. In the earlier version, drill-config.sh went to the trouble to compute JAVA_HOME and JAVA, but never exported them, making the work a bit of a waste. Now the values are exported.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---