Return-Path: <dev-return-23114-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 7EF6A200B56
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat, 16 Jul 2016 04:20:29 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 7D80C160A79; Sat, 16 Jul 2016 02:20:29 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id BE299160A61
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 16 Jul 2016 04:20:28 +0200 (CEST)
Received: (qmail 30855 invoked by uid 500); 16 Jul 2016 02:20:27 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 30839 invoked by uid 99); 16 Jul 2016 02:20:27 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jul 2016 02:20:27 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 794CBE0A3F; Sat, 16 Jul 2016 02:20:27 +0000 (UTC)
From: amansinha100 <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-519-drill@git.apache.org>
In-Reply-To: <git-pr-519-drill@git.apache.org>
Subject: [GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...
Content-Type: text/plain
Message-Id: <20160716022027.794CBE0A3F@git1-us-west.apache.org>
Date: Sat, 16 Jul 2016 02:20:27 +0000 (UTC)
archived-at: Sat, 16 Jul 2016 02:20:29 -0000

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r71059368
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java ---
    @@ -607,7 +607,14 @@ public long getRowCount() {
           fileSet = Sets.newHashSet(fileNames);
         }
     
    -    if (fileNames.isEmpty()) {
    +    List<String> finalFileNames;
    +    if (fileSet != null) {
    +      finalFileNames = Lists.newArrayList(fileSet);
    --- End diff --
    
    Commit #ef37b77 addresses this comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---