drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill issue #546: DRILL-4783: flatten operator should not throw exception if...
Date Thu, 21 Jul 2016 18:32:53 GMT
Github user jaltekruse commented on the issue:

    https://github.com/apache/drill/pull/546
  
    One small last comment. The method testNoResult() doesn't actually verify that they query
has no results, it just ignores whatever the query returns. I would recommend instead using
the expectsEmptyResultSet() method on the test builder and marking this method deprecated,
with a comment about the method on the builder as the preferred interface for such tests.
    
    With that small fix I'm +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message