drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #534: [DRILL-4743] HashJoin's not fully parallelized in q...
Date Fri, 15 Jul 2016 17:02:16 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/534#discussion_r71005763
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java
---
    @@ -251,7 +254,12 @@ public void setOption(final OptionValue value) {
         final String name = value.name.toLowerCase();
         final OptionValidator validator = getValidator(name);
     
    -    validator.validate(value); // validate the option
    +    /* If the validator depends on other options */
    +    if (validator instanceof DependentTypeValidators) {
    --- End diff --
    
    It would be good to avoid doing an instanceof (although sometimes it becomes unavoidable).
 Can you see what other changes are needed to achieve that ?  Seems like validate with a second
parameter can be implemented by DependentTypeValidators only and other validators could throw
an unsupported exception. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message