drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...
Date Thu, 14 Jul 2016 19:55:53 GMT
Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/518#discussion_r70872218
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
    @@ -56,11 +57,19 @@ public void trySimpleQueryWithLimit() throws Exception {
         test("select * from cp.`limit/test1.json` limit 10");
       }
     
    -  @Test// DRILL-1634 : retrieve an element in a nested array in a repeated map.  RepeatedMap
(Repeated List (Repeated varchar))
    +  @Test
    +  // DRILL-1634 : retrieve an element in a nested array in a repeated map.
    +  // RepeatedMap (Repeated List (Repeated varchar))
       public void testNestedArrayInRepeatedMap() throws Exception {
         test("select a[0].b[0] from cp.`jsoninput/nestedArray.json`");
         test("select a[0].b[1] from cp.`jsoninput/nestedArray.json`");
    -    test("select a[1].b[1] from cp.`jsoninput/nestedArray.json`");  // index out of the
range. Should return empty list.
    +    test("select a[1].b[1] from cp.`jsoninput/nestedArray.json`"); // index out
    --- End diff --
    
    comment format


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message