drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Date Thu, 14 Jul 2016 08:53:22 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r70770934
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    +   * If cluster version is the same as default, update option to current drillbit version.
    +   */
    +  private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint
drillbitEndpoint) {
    +    OptionValue versionOption = optionManager.getOption(ExecConstants.CLUSTER_VERSION);
    +    OptionValidator validator = SystemOptionManager.getValidator(ExecConstants.CLUSTER_VERSION);
    +    if (versionOption.equals(validator.getDefault())) {
    +      optionManager.setOption(OptionValue.createOption(
    --- End diff --
    
    @sudheeshkatkam 
    this was done on purpose [1]. Version is set as system option so administrator can update
it when cluster upgrade was done. This will help administrator to detect drillbits that were
not updated.
    
    [1] https://issues.apache.org/jira/browse/DRILL-4604?focusedCommentId=15241083&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15241083


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message