drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...
Date Tue, 12 Jul 2016 21:19:46 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r70524663
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
---
    @@ -212,8 +223,12 @@ public TableScan createTableScan(List<PartitionLocation> newPartitionLocation)
t
         }
     
         if (scanRel instanceof DrillScanRel) {
    -      final FileSelection newFileSelection = new FileSelection(null, newFiles, getBaseTableLocation());
    -      final FileGroupScan newGroupScan = ((FileGroupScan)((DrillScanRel)scanRel).getGroupScan()).clone(newFileSelection);
    +//      final FormatSelection formatSelection = (FormatSelection)((DynamicDrillTable)scanRel.getTable()).getSelection();
    +      final FormatSelection formatSelection = (FormatSelection)table.getSelection();
    +      final FileSelection newFileSelection = new FileSelection(null, newFiles, getBaseTableLocation(),
    +          cacheFileRoot, formatSelection.getSelection().getDirStatus());
    +      final FileGroupScan newGroupScan =
    +          ((FileGroupScan)((DrillScanRel)scanRel).getGroupScan()).clone(newFileSelection,
cacheFileRoot);
    --- End diff --
    
    This newFileSelection already has cacheFileRoot.  Do you think clone() only need take
FileSelection, since FileSelection has cacheFileRoot infor?
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message