drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #534: [DRILL-4743] HashJoin's not fully parallelized in q...
Date Tue, 12 Jul 2016 19:26:06 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/534#discussion_r70505090
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
    @@ -81,6 +83,11 @@
           new RangeLongValidator("planner.identifier_max_length", 128 /* A minimum length
is needed because option names are identifiers themselves */,
                                   Integer.MAX_VALUE, DEFAULT_IDENTIFIER_MAX_LENGTH);
     
    +  public static final OptionValidator FILTER_MIN_SELECTIVITY_ESTIMATE_FACTOR = new MinRangeDoubleValidator("planner.filter.min_selectivity_estimate_factor",
    --- End diff --
    
    This will reduce the flexibility for the user. I think we should still maintain one-on-one
mappings for RelMdRowCount, RelMdSelectivity and the selectivity upper/lower bounds. Selectivity
and bounds will be different e.g. for filters than for joins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message