drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #517: DRILL-4704 fix
Date Tue, 12 Jul 2016 15:13:20 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/517#discussion_r70458993
  
    --- Diff: exec/java-exec/src/main/codegen/templates/Decimal/CastIntDecimal.java ---
    @@ -64,7 +64,15 @@ public void setup() {
     
         public void eval() {
             out.scale = (int) scale.value;
    -        out.precision = (int) precision.value;
    --- End diff --
    
    I am not too familiar with the decimal type but taking a closer look at the fix I don't
think we should ignore the supplied precision.  Your fix will compute the precision in all
cases, which would be a performance overhead.  It should be computing only when supplied precision
is 0.  Thoughts ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message