drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #543: DRILL-4768: Fix leaking hive meta store connection ...
Date Tue, 12 Jul 2016 00:41:42 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/543#discussion_r70361935
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
    @@ -209,8 +213,10 @@ private DrillHiveMetaStoreClient(final HiveConf hiveConf) throws
MetaException {
           throws TException {
         try {
           return mClient.getAllTables(dbName);
    +    } catch (MetaException | UnknownDBException e) {
    +      throw e;
         } catch (TException e) {
    -      logger.warn("Failure while attempting to get hive tables", e);
    +      logger.warn("Failure while attempting to get hive tables. Retries once.", e);
    --- End diff --
    
    Add code to check if close() hits exception. In case close() fails with exception, we
log the exception and continue to reconnect(). This may leak connection. 
    
    However, we have to maintain hive metastore connection. Otherwise, next hive query may
fail, and the only way to continue is either re-enable hive storage plugin (which may then
leak a connection DRILL-4774), or re-start drillbit.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message