drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request #543: DRILL-4768: Fix leaking hive meta store connection ...
Date Mon, 11 Jul 2016 23:56:21 GMT
Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/543#discussion_r70358080
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/DrillHiveMetaStoreClient.java
---
    @@ -209,8 +213,10 @@ private DrillHiveMetaStoreClient(final HiveConf hiveConf) throws
MetaException {
           throws TException {
         try {
           return mClient.getAllTables(dbName);
    +    } catch (MetaException | UnknownDBException e) {
    +      throw e;
         } catch (TException e) {
    -      logger.warn("Failure while attempting to get hive tables", e);
    +      logger.warn("Failure while attempting to get hive tables. Retries once.", e);
    --- End diff --
    
    If it is Hive issue in reconnect(), can we close the client explicitly here until we upgrade
the Hive version? That way we can avoid more leaks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message