drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill issue #543: DRILL-4768: Fix leaking hive meta store connection in Dril...
Date Mon, 11 Jul 2016 19:58:53 GMT
Github user vkorukanti commented on the issue:

    https://github.com/apache/drill/pull/543
  
    Change seems reasonable to me. One thing: is the reconnect() call not closing the existing
connection? If yes why are we leaking the connections?
    
    I think there is one more place we need to do the same thing [1]. May be it is better
move this to DrillHiveMetastoreClient.
    
    [1] https://github.com/apache/drill/blob/master/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java#L94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message