drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #534: [DRILL-4743] HashJoin's not fully parallelized in q...
Date Mon, 11 Jul 2016 18:59:28 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/534#discussion_r70316280
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/PlannerSettings.java
---
    @@ -81,6 +81,11 @@
           new RangeLongValidator("planner.identifier_max_length", 128 /* A minimum length
is needed because option names are identifiers themselves */,
                                   Integer.MAX_VALUE, DEFAULT_IDENTIFIER_MAX_LENGTH);
     
    +  public static final OptionValidator FILTER_MIN_SELECTIVITY_ESTIMATE_FACTOR = new RangeDoubleValidator("planner.filter.min_selectivity_estimate_factor",
    +          0.0, 1.0, 0.0d);
    +  public static final OptionValidator FILTER_MAX_SELECTIVITY_ESTIMATE_FACTOR = new RangeDoubleValidator("planner.filter.max_selectivity_estimate_factor",
    --- End diff --
    
    can you add validation if the min does not exceed the max and vice versa. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message