drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #541: DRILL-4673: Implement "DROP TABLE IF EXISTS" for dr...
Date Fri, 08 Jul 2016 16:06:06 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/541#discussion_r70098588
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -199,15 +199,17 @@ SqlNode SqlCreateOrReplaceView() :
      * Parses a drop view statement.
      * DROP VIEW view_name;
      */
    -SqlNode SqlDropView() :
    +SqlNode SqlDropViewIfExists() :
     {
         SqlParserPos pos;
    +    boolean viewExistenceCheck = false;
     }
     {
         <DROP> { pos = getPos(); }
         <VIEW>
    +    [ <IF> <EXISTS> { viewExistenceCheck = true; } ]
         {
    -        return new SqlDropView(pos, CompoundIdentifier());
    +        return new SqlDropView(pos, CompoundIdentifier(), viewExistenceCheck);
    --- End diff --
    
    I did accordingly to `SqlCreateView` (without `OrReplace`) but agree with new names. Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message