drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #520: DRILL-3510: Add ANSI_QUOTES option so that Drill's ...
Date Thu, 07 Jul 2016 22:13:45 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/520#discussion_r69997336
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java
---
    @@ -219,11 +226,26 @@ public boolean storesMixedCaseQuotedIdentifiers() throws SQLException
{
         return super.storesMixedCaseQuotedIdentifiers();
       }
     
    -  // TODO(DRILL-3510):  Update when Drill accepts standard SQL's double quote.
       @Override
       public String getIdentifierQuoteString() throws SQLException {
         throwIfClosed();
    -    return "`";
    +    boolean systemOption = false;
    +    boolean sessionOption = false;
    +    String sql = "select type, bool_val from sys.options where name = 'parser.ansi_quotes'";
    --- End diff --
    
    Define a string constant for the option name, and use it across the code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message