drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #541: DRILL-4673: Implement "DROP TABLE IF EXISTS" for dr...
Date Thu, 07 Jul 2016 21:31:56 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/541#discussion_r69991381
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -245,15 +247,17 @@ SqlNode SqlCreateTable() :
      * Parses a drop table statement.
      * DROP TABLE table_name;
      */
    -SqlNode SqlDropTable() :
    +SqlNode SqlDropTableIfExists() :
     {
         SqlParserPos pos;
    +    boolean tableExistenceCheck = false;
     }
     {
         <DROP> { pos = getPos(); }
         <TABLE>
    +    [ <IF> <EXISTS> { tableExistenceCheck = true; } ]
         {
    -        return new SqlDropTable(pos, CompoundIdentifier());
    +        return new SqlDropTable(pos, CompoundIdentifier(), tableExistenceCheck);
    --- End diff --
    
    Same here. Should this be `return new SqlDropTableIfExists(..);`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message