Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-532-drill@git.apache.org>
In-Reply-To: <git-pr-532-drill@git.apache.org>
Subject: [GitHub] drill pull request #532: DRILL-4732: Update JDBC driver to use the new prepa...
Content-Type: text/plain
Message-Id: <20160628234214.3818EE08FE@git1-us-west.apache.org>
Date: Tue, 28 Jun 2016 23:42:14 +0000 (UTC)
archived-at: Tue, 28 Jun 2016 23:42:16 -0000

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/532#discussion_r68863584
  
    --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java ---
    @@ -362,12 +364,33 @@ public PreparedStatement prepareStatement(String sql, int resultSetType,
                                                 int resultSetHoldability) throws SQLException {
         throwIfClosed();
         try {
    -      DrillPrepareResult prepareResult = new DrillPrepareResult(sql);
    +      DrillRpcFuture<CreatePreparedStatementResp> respFuture = client.createPreparedStatement(sql);
    +
    +      CreatePreparedStatementResp resp;
    +      try {
    +        resp = respFuture.get();
    +      } catch (InterruptedException e) {
    +        // Preserve evidence that the interruption occurred so that code higher up
    +        // on the call stack can learn of the interruption and respond to it if it
    +        // wants to.
    +        Thread.currentThread().interrupt();
    +
    +        throw new SQLException( "Interrupted", e );
    --- End diff --
    
    Since the client connection is still alive, the query would continue to execute on the server and presumably still send back results. Where are the results consumed if an interrupt occurs here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---