Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-527-drill@git.apache.org>
In-Reply-To: <git-pr-527-drill@git.apache.org>
Subject: [GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs
Content-Type: text/plain
Message-Id: <20160628005120.9A43FDFFF8@git1-us-west.apache.org>
Date: Tue, 28 Jun 2016 00:51:20 +0000 (UTC)
archived-at: Tue, 28 Jun 2016 00:51:23 -0000

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/527#discussion_r68682152
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java ---
    @@ -0,0 +1,105 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.store;
    +
    +import org.apache.calcite.jdbc.SimpleCalciteSchema;
    +import org.apache.calcite.schema.SchemaPlus;
    +import org.apache.drill.common.AutoCloseables;
    +import org.apache.drill.common.exceptions.DrillRuntimeException;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.store.SchemaConfig.SchemaConfigInfoProvider;
    +import org.apache.drill.exec.util.ImpersonationUtil;
    +
    +import com.google.common.collect.Lists;
    +
    +import java.io.IOException;
    +import java.util.List;
    +
    +/**
    + * Class which creates new schema trees. It keeps track of newly created schema trees and closes them safely as
    + * part of {@link #close()}.
    + */
    +public class SchemaTreeProvider implements AutoCloseable {
    +  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(SchemaTreeProvider.class);
    +
    +  private final DrillbitContext dContext;
    +  private final List<SchemaPlus> schemaTreesToClose;
    +  private final boolean isImpersonationEnabled;
    +
    +  public SchemaTreeProvider(final DrillbitContext dContext) {
    +    this.dContext = dContext;
    +    schemaTreesToClose = Lists.newArrayList();
    +    isImpersonationEnabled = dContext.getConfig().getBoolean(ExecConstants.IMPERSONATION_ENABLED);
    +  }
    +
    +  /**
    +   * Return root schema with schema owner as the given user.
    +   *
    +   * @param userName Name of the user who is accessing the storage sources.
    +   * @param provider {@link SchemaConfigInfoProvider} instance
    +   * @return Root of the schema tree.
    +   */
    +  public SchemaPlus getRootSchema(final String userName, final SchemaConfigInfoProvider provider) {
    +    final String schemaUser = isImpersonationEnabled ? userName : ImpersonationUtil.getProcessUserName();
    +    final SchemaConfig schemaConfig = SchemaConfig.newBuilder(schemaUser, provider).build();
    +    return getRootSchema(schemaConfig);
    +  }
    +
    +  /**
    +   * Create and return a SchemaTree with given <i>schemaConfig</i>.
    +   * @param schemaConfig
    +   * @return
    +   */
    +  public SchemaPlus getRootSchema(SchemaConfig schemaConfig) {
    +    try {
    +      final SchemaPlus rootSchema = SimpleCalciteSchema.createRootSchema(false);
    +      dContext.getSchemaFactory().registerSchemas(schemaConfig, rootSchema);
    +      schemaTreesToClose.add(rootSchema);
    +      return rootSchema;
    +    } catch(IOException e) {
    +      // We can't proceed further without a schema, throw a runtime exception.
    +      final String errMsg = String.format("Failed to create schema tree: %s", e.getMessage());
    +      logger.error(errMsg, e);
    +      throw new DrillRuntimeException(errMsg, e);
    --- End diff --
    
    Probably should change this to be a UserException (as this will get sent back to the client)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---