Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-519-drill@git.apache.org>
In-Reply-To: <git-pr-519-drill@git.apache.org>
Subject: [GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...
Content-Type: text/plain
Message-Id: <20160616172145.D97EBDFDEF@git1-us-west.apache.org>
Date: Thu, 16 Jun 2016 17:21:45 +0000 (UTC)
archived-at: Thu, 16 Jun 2016 17:21:47 -0000

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r67387102
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java ---
    @@ -208,8 +209,18 @@ public DrillTable isReadable(DrillFileSystem fs, FileSelection selection,
             FileSystemPlugin fsPlugin, String storageEngineName, String userName)
             throws IOException {
           // TODO: we only check the first file for directory reading.
    -      if(selection.containsDirectories(fs)){
    -        if(isDirReadable(fs, selection.getFirstPath(fs))){
    +      if(selection.containsDirectories(fs)) {
    +        Path dirMetaPath = new Path(selection.getSelectionRoot(), Metadata.METADATA_DIRECTORIES_FILENAME);
    +        if (fs.exists(dirMetaPath)) {
    +          ParquetTableMetadataDirs mDirs = Metadata.readMetadataDirs(fs, dirMetaPath.toString());
    +          if (mDirs.getDirectories().size() > 0) {
    +            FileSelection dirSelection = FileSelection.createFromDirectories(mDirs.getDirectories(), selection);
    +            dirSelection.setExpandedPartial();
    +            return new DynamicDrillTable(fsPlugin, storageEngineName, userName,
    --- End diff --
    
    A comment then, perhaps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---