drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs
Date Fri, 17 Jun 2016 23:41:53 GMT
GitHub user vkorukanti opened a pull request:

    https://github.com/apache/drill/pull/527

    DRILL-4728: Add support for new metadata fetch APIs

    + Protobuf messages
       - GetCatalogsReq -> GetCatalogsResp
       - GetSchemasReq -> GetSchemasResp
       - GetTablesReq -> GetTablesResp
       - GetColumnsReq -> GetColumnsResp
    
    + Java Drill client changes
    
    + Server side changes to handle the metadata API calls
      - Provide a self contained `Runnable` implementation for each metadata API
        that process the requests and sends the response to client
      - In `UserWorker` override the `handle` method that takes the `ResponseSender` and
        send the response from the `handle` method instead of returning it.
      - Add a method for each new API to UserWorker to submit the metadata work.
      - Add a method `addNewWork(Runnable runnable)` to `WorkerBee` to submit a generic
        `Runnable` to `ExecutorService`.
      - Move out couple of methods from `QueryContext` into a separate interface
        `SchemaConfigInfoProvider` to enable instantiating Schema trees without the
        full `QueryContext`
    
    + RPC version is not yet updated. Will updated once all APIs are in master.
    
    @parthchandra Could you please review the patch?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkorukanti/drill DRILL-4728

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/527.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #527
    
----
commit 04f0057b4784e19ea4ecd411ff74ce6ad1d52259
Author: vkorukanti <venki@dremio.com>
Date:   2016-06-09T23:03:06Z

    DRILL-4728: Add support for new metadata fetch APIs
    
    + Protobuf messages
       - GetCatalogsReq -> GetCatalogsResp
       - GetSchemasReq -> GetSchemasResp
       - GetTablesReq -> GetTablesResp
       - GetColumnsReq -> GetColumnsResp
    
    + Java Drill client changes
    
    + Server side changes to handle the metadata API calls
      - Provide a self contained `Runnable` implementation for each metadata API
        that process the requests and sends the response to client
      - In `UserWorker` override the `handle` method that takes the `ResponseSender` and
        send the response from the `handle` method instead of returning it.
      - Add a method for each new API to UserWorker to submit the metadata work.
      - Add a method `addNewWork(Runnable runnable)` to `WorkerBee` to submit a generic
        `Runnable` to `ExecutorService`.
      - Move out couple of methods from `QueryContext` into a separate interface
        `SchemaConfigInfoProvider` to enable instantiating Schema trees without the
        full `QueryContext`
    
    Change-Id: I4509b1b1e747c5ef19654c48da87fe048a9740e8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message