drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chunhui Shi <c...@maprtech.com>
Subject Re: how to create a second pull request?
Date Thu, 09 Jun 2016 20:11:16 GMT
Usually I create one branch under my own repo for one fix, then submit a
new pull request from that branch.


On Thu, Jun 9, 2016 at 12:46 PM, Dave Oshinsky <doshinsky@commvault.com>
wrote:

> My user on github already has one Apache Drill fork, and one pull request (
> https://github.com/apache/drill/pull/372).  This has been sitting around
> for some 4 months now.  I have created a second JIRA (
> https://issues.apache.org/jira/browse/DRILL-4704), and have a fix for
> this issue as well.  Unlike my first fix, which I suspect is a
> controversial one (i.e., a "proper long-term fix" for that problem probably
> requires way more changes/rework than I can do, to support variable width
> decimal vectors), this second bug fix for DRILL-4704 is a very
> straightforward one, to one source file.
>
> It does not appear that I can create another pull request under my github
> login (nor can I create a second fork).  Ideally, I'd like to get my second
> fix accepted more quickly, while the first fix (DRILL-4184) may never be
> accepted as is (since it's really a work-around until more extensive
> changes can be made to fix it "properly").  What is the recommended course
> of action here?  Can I create a second pull request?   I don't see how to
> do this, without going in under a different github user.
>
> Dave Oshinsky
>
>
>
> ***************************Legal Disclaimer***************************
> "This communication may contain confidential and privileged material for
> the
> sole use of the intended recipient. Any unauthorized review, use or
> distribution
> by others is strictly prohibited. If you have received the message by
> mistake,
> please advise the sender by reply email and delete the message. Thank you."
> **********************************************************************

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message