drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs
Date Wed, 29 Jun 2016 00:05:06 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/527#discussion_r68865614
  
    --- Diff: protocol/src/main/protobuf/User.proto ---
    @@ -98,3 +106,141 @@ message BitToUserHandshake {
       optional string errorId = 4;
       optional string errorMessage = 5;
     }
    +
    +/*
    + * Enum indicating the request status.
    + */
    +enum RequestStatus {
    --- End diff --
    
    Although we haven't done this previously, I think we should use "UNKNOWN = 0" for enums
to avoid problems [mentioned here](http://androiddevblog.com/protocol-buffers-pitfall-adding-enum-values/).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message