drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #526: [Drill-4665] Partition pruning when LIKE predicate ...
Date Fri, 24 Jun 2016 17:46:15 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/526#discussion_r68434045
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestPartitionFilter.java ---
    @@ -362,4 +362,13 @@ public void testLogicalDirPruning2() throws Exception {
         testIncludeFilter(query, 1, "Filter", 10);
       }
     
    -}
    \ No newline at end of file
    +  @Test  //DRILL-4665: Partition pruning should occur when LIKE predicate on non-partitioning
column
    +  public void testPartitionFilterWithLike() throws Exception {
    --- End diff --
    
    This test looks fine.  Could you also add one where LIKE predicate is on the partitioning
column (it seems we don't have such a unit test). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message