drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #521: DRILL-4715: Fix java compilation error in run-time ...
Date Wed, 22 Jun 2016 20:54:06 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/521#discussion_r68133124
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java ---
    @@ -17,17 +17,54 @@
      */
     package org.apache.drill.exec;
     
    +import com.codahale.metrics.MetricRegistry;
    +import mockit.NonStrictExpectations;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.common.scanner.ClassPathScanner;
    +import org.apache.drill.exec.compile.CodeCompilerTestFactory;
    +import org.apache.drill.exec.exception.StoreException;
    +import org.apache.drill.exec.memory.RootAllocatorFactory;
     import org.apache.drill.exec.metrics.DrillMetrics;
    +import org.apache.drill.exec.physical.impl.OperatorCreatorRegistry;
    +import org.apache.drill.exec.planner.PhysicalPlanReaderTestFactory;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.server.options.SystemOptionManager;
    +import org.apache.drill.exec.store.sys.store.provider.LocalPersistentStoreProvider;
     import org.apache.drill.test.DrillTest;
     import org.junit.After;
    +import org.junit.BeforeClass;
    +
    +import static org.apache.drill.exec.RunRootExec.c;
     
     public class ExecTest extends DrillTest {
     
    +  protected static SystemOptionManager optionManager;
    +
       @After
       public void clear(){
         // TODO:  (Re DRILL-1735) Check whether still needed now that
         // BootstrapContext.close() resets the metrics.
         DrillMetrics.resetMetrics();
       }
     
    +
    +  @BeforeClass
    +  public static void setupOptionManager() throws Exception{
    +    final LocalPersistentStoreProvider provider = new LocalPersistentStoreProvider(c);
    +    provider.start();
    +    optionManager = new SystemOptionManager(PhysicalPlanReaderTestFactory.defaultLogicalPlanPersistence(c),
provider);
    +    optionManager.init();
    +  }
    +
    +  protected void initDrillbitContext(final DrillbitContext bitContext) throws Exception
{
    --- End diff --
    
    How about `mockDrillbitContext(...)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message