drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #521: DRILL-4715: Fix java compilation error in run-time ...
Date Wed, 22 Jun 2016 17:56:14 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/521#discussion_r68102305
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
---
    @@ -86,14 +88,16 @@ public static MappingSet getDefaultMapping() {
       }
     
       @SuppressWarnings("unchecked")
    -  ClassGenerator(CodeGenerator<T> codeGenerator, MappingSet mappingSet, SignatureHolder
signature, EvaluationVisitor eval, JDefinedClass clazz, JCodeModel model) throws JClassAlreadyExistsException
{
    +  ClassGenerator(CodeGenerator<T> codeGenerator, MappingSet mappingSet, SignatureHolder
signature, EvaluationVisitor eval, JDefinedClass clazz, JCodeModel model, OptionManager optionManager)
throws JClassAlreadyExistsException {
         this.codeGenerator = codeGenerator;
         this.clazz = clazz;
         this.mappings = mappingSet;
         this.sig = signature;
         this.evaluationVisitor = eval;
         this.model = model;
    -    blocks = (LinkedList<JBlock>[]) new LinkedList[sig.size()];
    +    this.optionManager = optionManager;
    --- End diff --
    
    Revise the code to pass in session option manager. 
    
    Also refactor some existing unit tests to pass in option manager to unit tests. 
    
    @sudheeshkatkam , could you please take a quick look to see if it addresses your comment?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message