drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #531: DRILL-4733: max(dir0) reading more columns than nec...
Date Tue, 21 Jun 2016 21:27:59 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/531#discussion_r67955187
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java
---
    @@ -126,8 +127,12 @@ CloseableRecordBatch getReaderBatch(FragmentContext context, EasySubScan
scan) t
         final ImplicitColumnExplorer columnExplorer = new ImplicitColumnExplorer(context,
scan.getColumns());
     
         if (!columnExplorer.isSelectAllColumns()) {
    +      // We must make sure to pass a table column (not to be confused with implicit column)
to the underlying record reader.
    +      List<SchemaPath> tableColumns =
    --- End diff --
    
    Ok, I see.   Although this patch resolves this issue, I am thinking that without doing
a performance test it is not feasible to see the performance impact of the overall implicit
columns support.  It is a nice feature to have but I think we can give it a little more time
to go through functional and perf tests.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message