drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #519: DRILL-4530: Optimize partition pruning with metadat...
Date Mon, 20 Jun 2016 16:04:52 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r67716686
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -47,16 +47,25 @@
       private List<FileStatus> statuses;
     
       public List<String> files;
    +  /**
    +   * root path for the selections
    +   */
       public final String selectionRoot;
    +  /**
    +   * root path for the metadata cache file (if any)
    +   */
    +  public final String cacheFileRoot;
    --- End diff --
    
    When singlePartitionOpt is applied,  is it possible to update selectionRoot to be cacheFileRoot?
That is, we do not maintain cacheFileRoot separately. In stead, a FileSelection with updated
selectionRoot is used when singlePartitionOpt is applied. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message